kemalcr / kemal

Fast, Effective, Simple Web Framework

Home Page:https://kemalcr.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Broken StaticFileHandler spec in 1.0.0-dev

bcardiff opened this issue · comments

Due to crystal-lang/crystal#5212 the following spec no longer pass with 1.0.0-dev.

crystal spec spec/static_file_handler_spec.cr:51 # Kemal::StaticFileHandler should gzip a file if config is true, headers accept gzip and file is > 880 bytes

The underlying issue is that the response.headers["Content-Encoding"] is removed by the HTTP::Client. Everything is still working fine.

The spec could be rewritten using parse_headers_and_body method with decompress: false probably.