Giters

kedacore / charts

Helm charts for KEDA

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

After upgrading Keda to v2.12.0 the v1beta1.external.metrics.k8s.io API component is not getting updated and its out of sync.

vermaprateek695 opened this issue · comments

commented

Expected Behavior

After upgrading Keda to v2.12.0 all the components should be in sync .

Actual Behavior

After upgrading Keda to v2.12.0 the v1beta1.external.metrics.k8s.io API component is not getting updated and it shows out of sync. When looking at the desired and the acutal state of the manifest file we could see the insecureSkipTLSVerify: false this value in desrired manifest is not getting picked up by argocd

image

PR where insecureSkipTLSVerify: false was added explicitly https://github.com/kedacore/charts/pull/520/files

Steps to Reproduce the Problem

  1. Upgraded the Keda version to v2.12.0
  2. synced the changes with Argocd
  3. v1beta1.external.metrics.k8s.io API component is not getting synced and shows outofsync with difference in the manifest .

Specifications

  • KEDA Version: * v2.12.0
  • Platform & Version: Please elaborate
  • Kubernetes Version: 1.28
  • Scaler(s): Please elaborate

image

can you please suggest any workaround which can fix this issue as in production env the Keda application shows outofsync due to this issue and this needs to be resolved at earliest.

commented

Yup, we have the same issue in our ArgoCD. I think the issue here is that it is trying to enforce the default value, so it never appears in the resource (do kubectl get apiservice v1beta1.external.metrics.k8s.io -o yaml and you'll see it isn't there), as a result ArgoCD see this as a difference in the resource manifests. I see a few options here:

  1. Wait it out until it eventually gets removed in a later Helm release
  2. Add a toggle to Helm to enable/disable this via a value
  3. Add that value to ArgoCD's ignore list (this is what we'll probably do)
commented

Also ran into this, since the value is default and is not configurable in the helm chart should probably just remove it from the manifest. I didn't quite get what the change was fixing during upgrades, though ArgoCD might not have seen this issue since it doesn't use the normal Helm upgrade workflow.

If someone runs into this with ArgoCD you can use this ignoreDifferences config:

ignoreDifferences:
  - group: apiregistration.k8s.io
    kind: APIService
    jsonPointers:
      - /spec/insecureSkipTLSVerify
commented

Actually turns out ArgoCD does need to apply the manifest as is in the chart. Once the upgrade is through you can apply the ignoreDifferences config however.

So I think users can either ignore it and wait for the workaround to be removed from the chart or use the ignoreDifferences config. I don't think this issue is very important to flag on general troubleshooting for Keda. Either way I can't commit to OSS repos without going through a legal review with my company.

commented

Has this been fixed in v2.13?