keda metrics-apiserver Deployment is rendered with annotation with empty value

[Andy Cobaugh]

Helm chart fails to render correctly when prometheus.metricServer.enabled = true

The template is still using a value that was removed here

Expected Behavior

Helm chart for keda renders correctly

Actual Behavior

error validating "": error validating data: unknown object type "nil" in Deployment.spec.template.metadata.annotations.prometheus.io/path

Steps to Reproduce the Problem

1. Install keda chart 2.11.0 with the following: helm template keda kedacore/keda --skip-crds --set prometheus.metricServer.enabled=true --set additionalAnnotations.dummy=value

Specifications

• KEDA Version: 2.11.0
• Platform & Version: n/a
• Kubernetes Version: n/a
• Scaler(s): n/a

[Nitish Chauhan]

/assign

[Eamonn Mc]

Had a quick look but was unfortunately not able to reproduce successfully (Template works, the install doesn't) via:

helm repo add kedacore https://kedacore.github.io/charts 
helm repo update
helm search repo kedacore/keda
NAME                            CHART VERSION   APP VERSION     DESCRIPTION                                       
kedacore/keda                   2.11.1          2.11.1          Event-based autoscaler for workloads on Kubernetes

helm template keda kedacore/keda --skip-crds --set prometheus.metricServer.enabled=true --set additionalAnnotations.dummy=value

Checking at present

[Eamonn Mc]

Based on this I think its safe to confirm that the linked pr just need to remove that extra field.
PR here

[Jorge Turrado Ferrero]

The PR has been merged 😄