Upgrade to Chart 2.11.0 Throws Errors
pinkfloydx33 opened this issue · comments
Our Flux deployment of KEDA has attempted to automatically upgrade to the latest chart related a few minutes ago. It is failing and throwing the following message in the logs:
Helm upgrade failed: YAML parse error on keda/templates/manager/service.yaml: error converting YAML to JSON: yaml: line 7: did not find expected key
I don't have better logs at the moment as the above is what is reported by Flux on my HelmRelease
resources. I can try and do a manual install into the environment and see if I get a better error message, but it would need to wait until at least tomorrow.
Expected Behavior
Chart succeeds
Actual Behavior
Chart fails
Steps to Reproduce the Problem
- Have 2.10.2 installed
- Upgrade to 2.11.0
Values:
nodeSelector:
some/node.selector: 'true'
podIdentity:
azureWorkload:
clientId: ''
enabled: true
prometheus:
metricServer:
enabled: true
operator:
enabled: true
port: 8080
webhooks:
enabled: true
This is happening in multiple environments with similar values files.
Specifications
- KEDA Version: chart 2.10.2 -> 2.11.0
- Platform & Version: AKS
- Kubernetes Version: 1.25.6
🕵️♂️
Regression got introduced in #432 and is caused here:
https://github.com/kedacore/charts/blob/main/keda/templates/manager/service.yaml#L10-L13
Mitigation: Add additionalAnnotations
with dummy values
Fixing it btw
Thanks @tomkerkhove!
Any ETA for release? I'd rather not add annotations as a work around in the interim. My dev environments are set to pick up minor/patch releases automatically so it'll fix itself, but really no rush... Just curious
I dare to say we are gonna do the release in a few hours.
Creating one now