kean / Future

Streamlined Future<Value, Error> implementation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question - open to support swift on linux with this?

heckj opened this issue · comments

I was looking around at promise style libraries to help solve a problem in another project, and wanted to utilize this library. It's pretty close, but doesn't currently easily (and consistently) support swift on linux out of the box. I'm willing to make some tweaks and updates to enable that, but wanted to inquire first if that would be acceptable.

I've offered a partial (small) update to Package.swift in #10 - but I'd like to take it a bit further based on my initial exploration:

  • update the tests to push them slightly lower (into a subdirectory) to more easily exclude the Host IOS app
  • add swift test to macOS command line to validate that continues to work as expected (not just through xcodebuild)
  • add linux focused CI running the tests (in either .travis or .github actions, if you have a preference)
  • replace the arc4random usage in the test extensions with a more platform neutral https://developer.apple.com/documentation/swift/randomnumbergenerator

Please, go ahead, I would appreciate if you could add Linux support.