The extension does not work for elements in iframes
crdev opened this issue · comments
An error message is displayed when an attempt to build a snippet for an element inside an iframe is made.
I decided not to hold the release any longer. This haven't made to v0.4, but I'll use it in v0.5.
Did you encounter any issues with this patch?
No, it's just I haven't reviewed nor tested it yet and since I'll be offline for the next 2 days I decided to deploy everything that was already finished.
Sounds good. That patch is non-trivial, so might use some review/testing, indeed.
Hey! Any progress on this? Or is the extension on hold for now?
Hi Alexander, sorry that it took forever, I have no excuse for that.
Your code is pretty complicated and not directly related to the UI so I decided to move it from panel.js to a separate file: https://github.com/kdzwinel/SnappySnippet/blob/master/js/tools/InspectedContext.js . Let me know if you have any comments.
Tomorrow I'll also add the namespacing feature ( #19 ) and release the whole thing.
Thank you so much for all your help!
Hey Konrad,
No problem at all here! I just stumped across SnappySnippet (was scanning through my old work materials) and decided to check back. Thanks for the update!
Deployed with version 0.5 of the extension!
👍