Environment confusion when Connector is installed
EnderTurret opened this issue · comments
Basically, No Telemetry (1.7.0) gets confused and thinks it's running on Fabric when Connector (1.0.0-beta.28+1.20.1) and Forgified Fabric API (0.90.7+1.10.3+1.20.1) are installed. Here's a log file (notice the Error loading class: messages from Mixin).
I believe this happens because CommonUtil checks to see if a Fabric loader class doesn't exist as one of the conditions for running on Forge, which is not the case when Connector is installed. In my testing I wrote a coremod to verify that this is the problem (by replacing the contents of that method with a return true;) and that appeared to fix the issue, as the missing class messages no longer appeared.
Sounds like my initial suspicion and of course unanswered question was right and connector does mess this kinda mod up. Sorry, but I'm not going to be special-casing and workaround it, I'd consider this an issue on their side since they cause it.
Also worth noting that thanks to my fairly aggressive fallback, telemetry is still successfully disabled thanks to the authlib mixin, as you can see in the log.