Using `aria-label` can break compatibility with 3rd party code
joankaradimov opened this issue · comments
One example is dhtmlxGantt. A sample of its usage of aria-label can be seen here.
Overriding the default style for aria-label potentially makes any 3rd party library that does higher-level rendering incompatible with balloon.css.
Balloon.css only "activates" when using both aria-label and data-balloon-pos attributes. If an element has only aria-label it is not impacted.
This behavior solves the issue, no?
@kazzkiq - well, for example, you can see in the source here that you actually modify [aria-label] globally. And it's really easy to check. Open the example in the first post - see how it looks. Then, in it's source, modify the three relative URLs in the beginning to be absolute and then just add the CSS from balloon.css and check the result.
I've created a repository here to showcase it. Just download the file and open it in a browser. See how everything is shifted due to conflicting CSS.
You're totally right. We still have properties being assigned to every [aria-label] element.
v1.0.2 fixes this issue.