BaseNode.children is set as list, but get as tuple

[Laurent Verweijen]

It seems the children are set as a list, but are returned as a tuple.
I think it would make more sense to set/get it as the same type, probably a tuple.

It makes the following (no-op looking) code illegal:

node = Node("node")
node.children = node.children
# => TypeError: Children input should be list type, received input type <class 'tuple'>

It's risky too, because of the following:

root = Node("root")
mutable_children = list(map(Node, "abc"))

root.children = mutable_children
c = mutable_children.pop()

print(root.children)  # => (Node(/root/a, ), Node(/root/b, ))
print(c.parent)  # => Node(/root, )
raise ZeroDivisionError

[Kay Jan W.]

Thanks for spotting this issue! I have modified children to take in Iterable which can accept lists and tuples (and other iterable types) in v0.9.5 (unreleased yet but it is in the v0.9.5 branch). Do check it out and see if there are any other issues if not v0.9.5 will be rolled out soon 😃

[Abdur-Rahmaan Janhangeer]

@kayjan Suggest to keep this and #67 and such issues open until the release has been made.

[Kay Jan W.]

v0.9.5 is now live, do upgrade bigtree with pip install --upgrade bigtree to get the latest changes.