kavenegar / kavenegar-dotnet

Kavenegar API Client Writen In C#

Home Page:https://kavenegar.com/rest.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Async Methods

nildarar opened this issue · comments

It's great if you can add async methods to the project.

Thanks for your professional work ...

@nildarar
I've created a pull request #6
Supporting Async Methods and Cancellations

Hi, do you have any plan to add async API version? it's really annoying using sync version of API with .NET Core project and it has performance impacts on the application because of thread blocking.

Hi Dear . We have a merge request from Mr @HesamKashefi , after we checked it we get very good changes and we must accept it ,but in due to the Corona virus crisis and because all of our team members have been working remotely these points maybe execute with delay .We are committed to doing this as soon as possible.

Perhaps after two months, you had enough time to merge @mhadieskandari, hadn't you? By the way, I sent another pull request with minimal changes but I don't think it merged just like HesamKashefi 's pull request.

@mo-esmp @HesamKashefi

We are sorry for the delay. We appreciate you for your kindness and patience.

We have decided to create another repo for dotnet core to prevent some problems for old customers that need some changes and updates for old technologies.

Could you please do a pull request again on https://github.com/kavenegar/Kavenegar.Core?

Sure, I do ASASP.

@mo-esmp @HesamKashefi

We are sorry for the delay. We appreciate you for your kindness and patience.

We have decided to create another repo for dotnet core to prevent some problems for old customers that need some changes and updates for old technologies.

Could you please do a pull request again on https://github.com/kavenegar/Kavenegar.Core?

I did mine,
I have to mention that I removed UrlEncoding from messages because KavenegarAPI is just ignoring them!

@HesamKashefi Thanks a lot. I will check it and will give you a response.