stable kons-9 commit
awolven opened this issue · comments
What is the most recent stable kons-9 commit, where everything was testing fine?
The current main branch.
How do you run the demos?
…On Sun, Nov 6, 2022 at 10:08 PM Kaveh Kardan ***@***.***> wrote:
The current main branch.
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMML6XSOFOJL5AZPQTHDWHB6CZANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
The function kons-9::p+ is undefined.
…On Sun, Nov 6, 2022 at 10:16 PM Andrew Wolven ***@***.***> wrote:
How do you run the demos?
On Sun, Nov 6, 2022 at 10:08 PM Kaveh Kardan ***@***.***>
wrote:
> The current main branch.
>
> —
> Reply to this email directly, view it on GitHub
> <#169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABGMML6XSOFOJL5AZPQTHDWHB6CZANCNFSM6AAAAAARYYK6B4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
The whole "point" system seems to have been ripped out of the latest
commits for a few days and none of the demos actually work.
…On Sun, Nov 6, 2022 at 11:11 PM Andrew Wolven ***@***.***> wrote:
The function kons-9::p+ is undefined.
On Sun, Nov 6, 2022 at 10:16 PM Andrew Wolven ***@***.***> wrote:
> How do you run the demos?
>
> On Sun, Nov 6, 2022 at 10:08 PM Kaveh Kardan ***@***.***>
> wrote:
>
>> The current main branch.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#169 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AABGMML6XSOFOJL5AZPQTHDWHB6CZANCNFSM6AAAAAARYYK6B4>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
The demos work on my machine, and I pushed to main on Friday.
We're using point-origin.lisp so it's p:+ now. But I just checked and p+ also works.
To run the demos:
(in-package :kons-9)
(run)
Then eval the demos.
I'll run some tests in the morning.
(find-package :p)
--> nil
grep -r point-origin
kons-9.asd: (:file "src/kernel/point-origin")
There is no p+ definition in src/kernel/point-origin.lisp
…On Sun, Nov 6, 2022 at 11:51 PM Kaveh Kardan ***@***.***> wrote:
The demos work on my machine, and I pushed to main on Friday.
We're using point-origin.lisp so it's p:+ now. But I just checked and p+
also works.
To run the demos:
(in-package :kons-9)
(run)
Then eval the demos.
I'll run some tests in the morning.
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMKC73H7DIIXA2JIL3TWHCKGTANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
(defun p+ (a b) (p! (+ (p:x a) (p:x b)) (+ (p:y a) (p:y b)) (+ (p:z a) (p:z
b))))
eval:
(with-clear-scene
(add-shape *scene* (make-cut-cube 2.0)))
The function kons-9::p/ is undefined.
something got ripped out
…On Mon, Nov 7, 2022 at 4:17 AM Andrew Wolven ***@***.***> wrote:
(find-package :p)
--> nil
grep -r point-origin
kons-9.asd: (:file "src/kernel/point-origin")
There is no p+ definition in src/kernel/point-origin.lisp
On Sun, Nov 6, 2022 at 11:51 PM Kaveh Kardan ***@***.***>
wrote:
> The demos work on my machine, and I pushed to main on Friday.
>
> We're using point-origin.lisp so it's p:+ now. But I just checked and p+
> also works.
>
> To run the demos:
> (in-package :kons-9)
> (run)
> Then eval the demos.
>
> I'll run some tests in the morning.
>
> —
> Reply to this email directly, view it on GitHub
> <#169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABGMMKC73H7DIIXA2JIL3TWHCKGTANCNFSM6AAAAAARYYK6B4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
That's a good candidate for the next thing to add to the test suite. :-) I can pick up but maybe you are interested in that topic @awolven ?
Yes, I'm interested in expanding the test suite, if that is what you're
asking.
…On Mon, Nov 7, 2022 at 7:16 AM Michaël Le Barbier ***@***.***> wrote:
That's a good candidate for the next thing to add to the test suite. :-) I
can pick up but maybe you are interested in that topic @awolven
<https://github.com/awolven> ?
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMO7QOO5PFE3WMP7XG3WHD6MPANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
on windows:
cd ~/AppData/local
find . -name \*.fasl -delete
;; make your computer as fresh as a new user would have it on the first
download of kons-9
you should also be able to reproduce this if you do:
(ql:update-dist "quicklisp")
…On Mon, Nov 7, 2022 at 7:38 AM Luke Gorrie ***@***.***> wrote:
@awolven <https://github.com/awolven> The snippet you posted works fine
for me on Linux with commit 308b121
<308b121>
i.e. current tip of the main branch. I wonder what is different on your
machine? (Is it a platform-related issue?)
Result:
[image: Screenshot from 2022-11-07 14-37-00]
<https://user-images.githubusercontent.com/13791/200324252-c220dc0d-8c2d-4e38-8933-6fb8676b47b7.png>
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMOS7NBHVTKYW67RSWDWHEA6BANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
I have gone about as far as I can with this vulkan port until I get kons-9
polygons working.
…On Mon, Nov 7, 2022 at 8:20 AM Andrew Wolven ***@***.***> wrote:
on windows:
cd ~/AppData/local
find . -name \*.fasl -delete
;; make your computer as fresh as a new user would have it on the first
download of kons-9
you should also be able to reproduce this if you do:
(ql:update-dist "quicklisp")
On Mon, Nov 7, 2022 at 7:38 AM Luke Gorrie ***@***.***>
wrote:
> @awolven <https://github.com/awolven> The snippet you posted works fine
> for me on Linux with commit 308b121
> <308b121>
> i.e. current tip of the main branch. I wonder what is different on your
> machine? (Is it a platform-related issue?)
>
> Result:
>
> [image: Screenshot from 2022-11-07 14-37-00]
> <https://user-images.githubusercontent.com/13791/200324252-c220dc0d-8c2d-4e38-8933-6fb8676b47b7.png>
>
> —
> Reply to this email directly, view it on GitHub
> <#169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABGMMOS7NBHVTKYW67RSWDWHEA6BANCNFSM6AAAAAARYYK6B4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
Tagging @JMC-design who did the point-origin port, in case he has any ideas of what may be going on.
Can you at least replicate it?
…On Mon, Nov 7, 2022 at 11:38 AM Kaveh Kardan ***@***.***> wrote:
Tagging @JMC-design <https://github.com/JMC-design> who did the
point-origin port, in case he has any ideas of what may be going on.
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMPKK32RGAVFEHAV2TLWHE5BFANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
I'm on a new machine. I just cloned the repo and ran it. Everything seems to be fine. origin is in depends, the nickname is there and the demos work.
This seems to be an old file @awolven is looking at.
Yes, I'm interested in expanding the test suite, if that is what you're asking.
…
Yes, there is and introductory discussion in #112, you can skim towards the end to find the interesting bits. I'm also happy to answer questions and provide any help. We could also pair some time over zoom if you're interested, I believe it's a great way to quickly get started!
Ok, these are the steps I am taking:
cd ~/AppData/Local
find . -name \*.fasl -delete
git clone ***@***.***:awolven/kons-9.git kons-9-test
I edit my .sbclrc to only point to ~/kons-9-test/ not ~/kons-9/
I start lisp:
(ql:update-client)
(ql:update-dist "quicklisp")
(ql:quickload :kons-9)
(kons-9::run)
I open the file :
~/kons-9-test/test/demo-kernel.lisp
I cut and paste this form into the repl:
(with-clear-scene
(add-shape *scene* (make-cut-cube 2.0)))
I get:
The function kons-9::p+ is undefined.
I cd to ~/kons-9-test/
grep -r "p+"
There is no definition of p+ that isn't commented out.
And the commented out definition doesn't work.
Apparently quicklisp is not providing a definition of p+ either.
Can I please get the source code to p+ and brethren?
I can try it on Linux and Mac if you really want me to, but I am telling
you, there is a problem, at least on Windows.
…On Mon, Nov 7, 2022 at 12:34 PM Michaël Le Barbier ***@***.***> wrote:
Yes, I'm interested in expanding the test suite, if that is what you're
asking.
… <#m_-4675560929835420033_>
Yes, there is and introductory discussion in #112
<#112>, you can skim towards the
end to find the interesting bits. I'm also happy to answer questions and
provide any help. We could also pair some time over zoom if you're
interested, I believe it's a great way to quickly get started!
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMP4IESF4VDVUMB3OILWHFDRRANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
shit, i found a typo
…On Mon, Nov 7, 2022 at 2:07 PM Andrew Wolven ***@***.***> wrote:
Ok, these are the steps I am taking:
cd ~/AppData/Local
find . -name \*.fasl -delete
git clone ***@***.***:awolven/kons-9.git kons-9-test
I edit my .sbclrc to only point to ~/kons-9-test/ not ~/kons-9/
I start lisp:
(ql:update-client)
(ql:update-dist "quicklisp")
(ql:quickload :kons-9)
(kons-9::run)
I open the file :
~/kons-9-test/test/demo-kernel.lisp
I cut and paste this form into the repl:
(with-clear-scene
(add-shape *scene* (make-cut-cube 2.0)))
I get:
The function kons-9::p+ is undefined.
I cd to ~/kons-9-test/
grep -r "p+"
There is no definition of p+ that isn't commented out.
And the commented out definition doesn't work.
Apparently quicklisp is not providing a definition of p+ either.
Can I please get the source code to p+ and brethren?
I can try it on Linux and Mac if you really want me to, but I am telling
you, there is a problem, at least on Windows.
On Mon, Nov 7, 2022 at 12:34 PM Michaël Le Barbier <
***@***.***> wrote:
> Yes, I'm interested in expanding the test suite, if that is what you're
> asking.
> … <#m_-3264227415752971207_m_-4675560929835420033_>
>
> Yes, there is and introductory discussion in #112
> <#112>, you can skim towards
> the end to find the interesting bits. I'm also happy to answer questions
> and provide any help. We could also pair some time over zoom if you're
> interested, I believe it's a great way to quickly get started!
>
> —
> Reply to this email directly, view it on GitHub
> <#169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABGMMP4IESF4VDVUMB3OILWHFDRRANCNFSM6AAAAAARYYK6B4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
Ok I repeated the test with:
rm -rf ~/kons-9-test/
git clone ***@***.***:kaveh808/kons-9.git kons-9-test
I get the same issue.
There is no definition of p+ in kons-9-test which I cloned directly from
Kaveh's repo.
…On Mon, Nov 7, 2022 at 2:07 PM Andrew Wolven ***@***.***> wrote:
shit, i found a typo
On Mon, Nov 7, 2022 at 2:07 PM Andrew Wolven ***@***.***> wrote:
> Ok, these are the steps I am taking:
>
> cd ~/AppData/Local
> find . -name \*.fasl -delete
>
> git clone ***@***.***:awolven/kons-9.git kons-9-test
>
> I edit my .sbclrc to only point to ~/kons-9-test/ not ~/kons-9/
>
> I start lisp:
>
> (ql:update-client)
>
> (ql:update-dist "quicklisp")
>
> (ql:quickload :kons-9)
>
> (kons-9::run)
>
> I open the file :
>
> ~/kons-9-test/test/demo-kernel.lisp
>
> I cut and paste this form into the repl:
>
> (with-clear-scene
> (add-shape *scene* (make-cut-cube 2.0)))
>
> I get:
> The function kons-9::p+ is undefined.
>
> I cd to ~/kons-9-test/
> grep -r "p+"
>
> There is no definition of p+ that isn't commented out.
> And the commented out definition doesn't work.
>
> Apparently quicklisp is not providing a definition of p+ either.
>
> Can I please get the source code to p+ and brethren?
>
> I can try it on Linux and Mac if you really want me to, but I am telling
> you, there is a problem, at least on Windows.
>
> On Mon, Nov 7, 2022 at 12:34 PM Michaël Le Barbier <
> ***@***.***> wrote:
>
>> Yes, I'm interested in expanding the test suite, if that is what you're
>> asking.
>> …
>> <#m_8510335330334631525_m_-3264227415752971207_m_-4675560929835420033_>
>>
>> Yes, there is and introductory discussion in #112
>> <#112>, you can skim towards
>> the end to find the interesting bits. I'm also happy to answer questions
>> and provide any help. We could also pair some time over zoom if you're
>> interested, I believe it's a great way to quickly get started!
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#169 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AABGMMP4IESF4VDVUMB3OILWHFDRRANCNFSM6AAAAAARYYK6B4>
>> .
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
p+ is defined in point-origin:
(defmacro def-point-func-1 (op)
`(defun ,(concat-syms 'p op) (p val)
(ctypecase val
(p:vec (,(find-symbol (symbol-name op) 'p) p val))
(number (p! (,op (p:x p) val)
(,op (p:y p) val)
(,op (p:z p) val))))))
(def-point-func-1 +)
(def-point-func-1 -)
(def-point-func-1 *)
(def-point-func-1 /)
@mikelevins Are you having any trouble running on Windows?
;; here's the macroexpansion:
(defun |p+| (p val)
(ctypecase val
(p:vec (p:+ p val))
(number (p! (+ (p:x p) val) (+ (p:y p) val) (+ (p:z p) val)))))
This is brittle code. Here's what the macro should be:
(defmacro def-point-func-1 (op)
`(defun ,(intern (concatenate 'string "P" (symbol-name op))) (p val)
(ctypecase val
(p:vec (,(find-symbol (symbol-name op) 'p) p val))
(number (p! (,op (p:x p) val)
(,op (p:y p) val)
(,op (p:z p) val))))))
…On Mon, Nov 7, 2022 at 2:29 PM Kaveh Kardan ***@***.***> wrote:
@mikelevins <https://github.com/mikelevins> Are you having any trouble
running on Windows?
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMJ3ECO5THKK7PW3PSLWHFRD3ANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Thanks for catching this Andrew.
I can make this change in my next merge with main, unless you prefer making an issue and a pull request?
Go ahead and make the change and merge it. What we should do is run the
tests with *print-case* and *read-case* set to alternate settings. I was
going to make an issue (when the time was right, I guess now...) with
*read-default-float-format* set to double-float and (pushnew
:3d-vectors-double-floats *features*) which are much bigger problems that
need testing/fixes. Those are important to the scientific/engineering
community which I am a part of.
…On Mon, Nov 7, 2022 at 6:07 PM Kaveh Kardan ***@***.***> wrote:
Thanks for catching this Andrew.
I can make this change in my next merge with main, unless you prefer
making an issue and a pull request?
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMIOP256J246FNF26E3WHGKVXANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Oh yeah, and there is also the case that in computer-aided design, Z is UP,
while in the content creation community Y is UP that I should go ahead and
mention.
…On Mon, Nov 7, 2022 at 6:27 PM Andrew Wolven ***@***.***> wrote:
Go ahead and make the change and merge it. What we should do is run the
tests with *print-case* and *read-case* set to alternate settings. I was
going to make an issue (when the time was right, I guess now...) with
*read-default-float-format* set to double-float and (pushnew
:3d-vectors-double-floats *features*) which are much bigger problems that
need testing/fixes. Those are important to the scientific/engineering
community which I am a part of.
On Mon, Nov 7, 2022 at 6:07 PM Kaveh Kardan ***@***.***>
wrote:
> Thanks for catching this Andrew.
>
> I can make this change in my next merge with main, unless you prefer
> making an issue and a pull request?
>
> —
> Reply to this email directly, view it on GitHub
> <#169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABGMMIOP256J246FNF26E3WHGKVXANCNFSM6AAAAAARYYK6B4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
Go ahead and make issues for the double-float issue and Z-up as an option.
Did this macro fix your problem on Windows?
Yes.
…On Mon, Nov 7, 2022 at 6:54 PM Kaveh Kardan ***@***.***> wrote:
Go ahead and make issues for the double-float issue and Z-up as an option.
Did this macro fix your problem on Windows?
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGMMJ46WWYM77WN7LCHQTWHGQDZANCNFSM6AAAAAARYYK6B4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>