Make more compatible for browser use. Pass TypeScript checks

Question

Make more compatible for browser use. Pass TypeScript checks

AckerApple opened this issue 6 years ago · comments

When compiling code for updated versions of TypeScript, it now checks the require statements and several errors are being thrown:

ERROR in ../node_modules/jsonexport/dist/core/join-rows.js
Module not found: Error: Can't resolve 'os'
ERROR in ../node_modules/jsonexport/dist/parser/csv.js
Module not found: Error: Can't resolve 'os'
ERROR in ../node_modules/jsonexport/dist/core/stream.js
Module not found: Error: Can't resolve 'stream'
ERROR in ../node_modules/jsonexport/dist/parser/csv.js
Module not found: Error: Can't resolve 'stream'

It seems require('stream') and require('os') are not even really needed for the browser. The EOL can just be backslash "\n" in the browser. And stream is not needed if a callback is provided.

I manually edited the node_modules/jsonexport files and all came out well and built to browser. I will need to find the most compatible way to have all files live in harmony and that the dist folder has NO node based requires.

Will have to complete this with-in a weeks time at max. Please be available to publish to npm when I have completed

kaue · Answer 1 · Fri Jun 15 2018 01:01:01 GMT+0800 (China Standard Time)

I will be avaliable for the publish, but i already added you as a collaborator so you should be able to publish also

Acker Dawn Apple · Answer 2 · Fri Jun 15 2018 02:25:45 GMT+0800 (China Standard Time)

Please check out my push when you get a chance.

Commit link here

Change log

v2.2.0 - Better browser distribution
- Browser based files in dist are overwritten for best browser building
- Found unused code and removed
- Updated all depencies
  - Some had minor version changes
  - This package now changes its minor from 2.1 to 2.2
  - Added npm-run-all to safely run npm multi commands across all operating systems

Acker Dawn Apple · Answer 3 · Fri Jun 15 2018 21:30:22 GMT+0800 (China Standard Time)

I'm going to try and publish this code to npm. I feel real confident of it and in need of it for my team.

kaue · Answer 4 · Fri Jun 15 2018 21:31:54 GMT+0800 (China Standard Time)

@AckerApple go for it!

Acker Dawn Apple · Answer 5 · Fri Jun 15 2018 21:32:18 GMT+0800 (China Standard Time)

Published. I really am humbled and extra appreciative of being entrusted to maintain and publish this package. Quite the honor.

kaue · Answer 6 · Fri Jun 15 2018 21:33:49 GMT+0800 (China Standard Time)

@AckerApple I am honoured to have you helping maintaining this package!
Really, thanks Acker!

Acker Dawn Apple · Answer 7 · Fri Jun 15 2018 21:36:43 GMT+0800 (China Standard Time)

Would be cool to cross your path someday. Your github icon is soulfully great to see, zoomed in to see you got a smile. Little things, the little things.

kaue · Answer 8 · Fri Jun 15 2018 22:44:04 GMT+0800 (China Standard Time)

Yes, i want to meet you too! send me an email (check my gh profile) with your skype, whatsapp or telegram info =)