GitHub API query parameter deprecation
dnsge opened this issue · comments
Describe the bug
GitHub is deprecating passing personal access tokens as query arguments, which is the method that this extension uses.
To Reproduce
Use the program with a personal access token. GitHub will (probably) send you an email about the API being deprecated, as they did to me.
Expected behavior
Use of correct API authorization method.
Desktop (please complete the following information):
- OS: MacOS
- Browser: Brave
- Version: 1.2.43
Additional context
Info about deprecation: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
Solution: https://developer.github.com/v3/auth/#via-oauth-and-personal-access-tokens
Basically to fix, instead of passing user token as query argument (as done here: requestLoc.ts), set the header: Authorization: token <token>
Hi @dnsge . I will fix it by the end of the day. Thank you for your issue and i hope this extension useful for you
@dnsge Dear Dan, I fixed that. Thank you very much. You helped a lot of people - about 8K. We are really appreciate your message - mosts of them of course know nothing)))) But we know with you - that we are (with you) saved their asses )))
I sent new release, with this fix only, named 8.2.2 - in a few hours it have to be available for us. Current status - pending for review (new procedure by Google. Can't b;ame them)) )
Have a good day man)
