kartoza / docker-pg-backup

A cron job that will back up databases running in a docker postgres container

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add possbility to use Docker secrets

LuViKu opened this issue · comments

The kartoza postgis docker compose allows the usage of e.g. POSTGRES_PASS_FILE in order to pass secrets into the container. It would be nice to be able to provide secret credentials to the docker-pg-backup image via the same way.

commented

Can't you do that already, I thought this is already possible https://github.com/kartoza/docker-pg-backup/blob/master/scripts/start.sh#L70

Sorry my bad. I totally missed the part of the start.sh script. I think it would be helpful to include this in the readme as well. Once I have time I can update the readme and create a pull request, if that would help you guys out.

Anyway thanks for the awesome repo! Have a good one.

commented

PR are always welcome