Giters

karrioapi / karrio

Programmable Shipping API (self-hosted)

Home Page:https://karrio.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DHL Express: registration numbers missing

DarkSwoop opened this issue · comments

commented

Describe the bug
When I enter data into the customs identifications section, they are not transmitted to DHL.

To Reproduce
Steps to reproduce the behavior:

  1. Create a shipment
  2. open the "edit customs" dialog
  3. enter data into the customs identification section
  4. buy a label
  5. look at the shipment request log

Screenshots

customs-identifications
commented

After the first investigations, a race condition issue appears on the create shipment/label form state update.
The overall state management for the shipment is a bit complex and needs improvement.

(The create label is somehow sent before the customs mutation is committed.)

I hope to address it in this PR #489

commented

That sounds excellent. Do you already have an idea when the release for this will come? And another question: Are the customs identification information stored somewhere so that one doesn't have to enter them with every new shipment?

commented

Hi @DarkSwoop,

I released the patch with your PR as part of 2023.9.13. I am hoping to have #489 merged and released by late Saturday this week.

You are right about the customs identification information. We used to have customs templates similar to addresses and parcels but retired them as it was a bit clunky. I am thinking of adding a user preference where things like that could be stored and automatically prefilled during shipments. It will also have things like (default measurement types, and label types ...)
What do you think?

Thank you so much for sponsoring the project. It means a lot.
A couple of things I want to ask:

  • Would you please email me at dan@karrio.io with a few bullet points of things you hope to see added to the project in terms of direction and features that would be helpful for you and your customers?
  • I would like to feature you or your company logo in the README as sponsor.

Cheers

commented

Hi @DarkSwoop,

I released the patch with your PR as part of 2023.9.13. I am hoping to have #489 merged and released by late Saturday this week.

You are right about the customs identification information. We used to have customs templates similar to addresses and parcels but retired them as it was a bit clunky. I am thinking of adding a user preference where things like that could be stored and automatically prefilled during shipments. It will also have things like (default measurement types, and label types ...) What do you think?

Thank you so much for sponsoring the project. It means a lot. A couple of things I want to ask:

* Would you please email me at [dan@karrio.io](mailto:dan@karrio.io) with a few bullet points of things you hope to see added to the project in terms of direction and features that would be helpful for you and your customers?

* I would like to feature you or your company logo in the README as sponsor.

Cheers

Hi @danh91 ,
Did you receive my email?

commented

Hi @DarkSwoop,
I have received your email. Thanks for taking the time. I am wrapping up the 2024.2 official release early next week.
I should have the DHL customs config sorted out with auto fill so that users don't have to add them over and over again.