Giters

karlwancl / YahooFinanceApi

A handy Yahoo! Finance api wrapper, based on .NET Standard 2.0

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update this library and Quandle.NET to use .NET core 2.0?

mayerwin opened this issue · comments

commented

Each time I am using this library in a project targeting .NET Framework 4.6.2, it causes a crazy number of references to System.* assemblies to be added. My understanding is that this issue has been solved with .NET core 2.0. Could you look into upgrading YahooFinanceApi (and also Quandle.NET which I see you authored) for better support?

commented

@mayerwin the package is updated, please see if it works 😄

commented

Thanks for the fast update!

It looks much cleaner, it added 16 Microsoft related references instead of 50 previously.
Now:

+  <package id="System.Diagnostics.DiagnosticSource" version="4.0.0" targetFramework="net462" />
+  <package id="System.Globalization" version="4.0.11" targetFramework="net462" />
+  <package id="System.IO.FileSystem" version="4.0.1" targetFramework="net462" />
+  <package id="System.IO.FileSystem.Primitives" version="4.0.1" targetFramework="net462" />
+  <package id="System.Linq" version="4.1.0" targetFramework="net462" />
+  <package id="System.Net.Http" version="4.1.0" targetFramework="net462" />
+  <package id="System.Reflection" version="4.3.0" targetFramework="net462" />
+  <package id="System.Reflection.TypeExtensions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.Serialization.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Algorithms" version="4.2.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Encoding" version="4.0.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Primitives" version="4.0.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.X509Certificates" version="4.1.0" targetFramework="net462" />
+  <package id="System.Text.Encoding.CodePages" version="4.0.1" targetFramework="net462" />
+  <package id="Microsoft.NETCore.Portable.Compatibility" version="1.0.1" targetFramework="net462" />
+  <package id="Microsoft.Win32.Primitives" version="4.0.1" targetFramework="net462" />

Before:

+  <package id="System.Console" version="4.3.0" targetFramework="net462" />
+  <package id="System.Diagnostics.Debug" version="4.3.0" targetFramework="net462" />
+  <package id="System.Diagnostics.DiagnosticSource" version="4.3.0" targetFramework="net462" />
+  <package id="System.Diagnostics.Tools" version="4.3.0" targetFramework="net462" />
+  <package id="System.Diagnostics.Tracing" version="4.3.0" targetFramework="net462" />
+  <package id="System.Globalization" version="4.3.0" targetFramework="net462" />
+  <package id="System.Globalization.Calendars" version="4.3.0" targetFramework="net462" />
+  <package id="System.IO" version="4.3.0" targetFramework="net462" />
+  <package id="System.IO.Compression" version="4.3.0" targetFramework="net462" />
+  <package id="System.IO.Compression.ZipFile" version="4.3.0" targetFramework="net462" />
+  <package id="System.IO.FileSystem" version="4.3.0" targetFramework="net462" />
+  <package id="System.IO.FileSystem.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Linq" version="4.3.0" targetFramework="net462" />
+  <package id="System.Linq.Expressions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Net.Http" version="4.3.0" targetFramework="net462" />
+  <package id="System.Net.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Net.Sockets" version="4.3.0" targetFramework="net462" />
+  <package id="System.ObjectModel" version="4.3.0" targetFramework="net462" />
+  <package id="System.Reflection" version="4.3.0" targetFramework="net462" />
+  <package id="System.Reflection.Extensions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Reflection.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Reflection.TypeExtensions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Resources.ResourceManager" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.Extensions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.Handles" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.InteropServices" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.InteropServices.RuntimeInformation" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.Numerics" version="4.3.0" targetFramework="net462" />
+  <package id="System.Runtime.Serialization.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Algorithms" version="4.3.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Encoding" version="4.3.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="System.Security.Cryptography.X509Certificates" version="4.3.0" targetFramework="net462" />
+  <package id="System.Text.Encoding" version="4.3.0" targetFramework="net462" />
+  <package id="System.Text.Encoding.CodePages" version="4.0.1" targetFramework="net462" />
+  <package id="System.Text.Encoding.Extensions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Text.RegularExpressions" version="4.3.0" targetFramework="net462" />
+  <package id="System.Threading" version="4.3.0" targetFramework="net462" />
+  <package id="System.Threading.Tasks" version="4.3.0" targetFramework="net462" />
+  <package id="System.Threading.Timer" version="4.3.0" targetFramework="net462" />
+  <package id="System.Xml.ReaderWriter" version="4.3.0" targetFramework="net462" />
+  <package id="System.Xml.XDocument" version="4.3.0" targetFramework="net462" />
+  <package id="System.AppContext" version="4.3.0" targetFramework="net462" />
+  <package id="System.Collections" version="4.3.0" targetFramework="net462" />
+  <package id="System.Collections.Concurrent" version="4.3.0" targetFramework="net462" />
+  <package id="Microsoft.NETCore.Platforms" version="1.1.0" targetFramework="net462" />
+  <package id="Microsoft.NETCore.Portable.Compatibility" version="1.0.1" targetFramework="net462" />
+  <package id="Microsoft.Win32.Primitives" version="4.3.0" targetFramework="net462" />
+  <package id="NETStandard.Library" version="1.6.1" targetFramework="net462" />

I guess this is normal. Hopefully it'll be enough resolve some weird DLL conflicts with System libraries I was encountering.

Thanks again!

commented

Just a heads up, Quandle.NET's headline still reads: "A .NET wrapper built on Quandl v3 REST API, based on .NET standard 1.4".

commented

@mayerwin oops, I have missed that. Thanks for pointing out, haha 😄