karlvr / openapi-generator-plus

A code generator for OpenAPI written in node and designed to have pluggable generators

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

error in security logic of openIdConnect

clapton2008 opened this issue · comments

There is no way to correctly get Claims when using the OpenID Connect type. The Open Api specification allows you to use Claims, and I attach the link. https://swagger.io/docs/specification/authentication/openid-connect-discovery/ and in the code, due to the fact that cut off Scopes when there are no flows, there is no way to get them. https://github.com/karlvr/openapi-generator-plus/blob/master/packages/core/src/process/security.ts#L89 the logic of processing and there is below, but it is possible when something went wrong) scopes: scopeObjects was null when use OpenID Connect

Hi! Thank you very much for this. I haven't used OpenApiConnect with OpenAPI so I've probably just overlooked it. Do you want to suggest a PR to correct this? I presume we'll need to add some more data into the types to store the claims?

@clapton2008 if you have a moment, would you be able to paste in an example spec so I can make sure that all of the required info is exposed?