Customize deny pattern still can be executed

[Gilang Virga Perdana]

Shellfirm version:

What happened:
Tried to customize the denied command, but it didn't work.

What you expected to happen:
what I think, shellfirm can customize commands that can be denied in addition to the default commands like in the shellfirm/checks directory. But it doesn't work well at my place

How to reproduce it (as minimally and precisely as possible):

• I declared the command I want to deny in .shellfirm/settings.yaml in the line deny_patterns_ids & includes
• I did a shellfirm config challenge
• I've seen my pattern customization already entered there
• but after I tried the command, it still works in other words it is not restricted by shellfirm. Unlike the default commands that shellfirm give such as git reset etc.

Anything else we need to know?:

• we all know that this app has big vision and i already feel it
• I am very happy that you build an application like this, it is very useful in my opinion
• Thanks @kaplanelad

OS:

• Ubuntu 20.04LTS Server

Evidence

• git reset command rejected as usual.
• openstack command not rejected as usual.

[Elad Kaplan]

Hey @gilangvperdana,
i'm not recommended to modify the setting manually.
to add a pattern to deny list, tap the command shellfirm config deny
See example:

[Gilang Virga Perdana]

Hey @gilangvperdana, i'm not recommended to modify the setting manually. to add a pattern to deny list, tap the command shellfirm config deny See example:

Thanks @kaplanelad it's working fine