created element is not a DOM node

Question

created element is not a DOM node

yoshuawuyts opened this issue 9 years ago · comments

The exposed element by titlebar() is not a DOM node:

This works fine with older methods such as Node.appendChild(), but newer methods like Node.insertBefore() don't like this.

I suspect the root issue is that the prototype is being overwritten, since domify returns proper DOM nodes. Thanks!

Yosh · Answer 1 · Fri May 29 2015 21:37:16 GMT+0800 (China Standard Time)

Welp, apparently I should read code before opening an issue. - https://github.com/kapetan/titlebar/blob/master/index.js#L58-L70

Would be neat if the exposed element inherited from HTMLElement though, though I'm not sure how it'll play with the custom CSS like on titlebar.appendTo().

Mirza Kapetanovic · Answer 2 · Sat May 30 2015 18:41:07 GMT+0800 (China Standard Time)

I don't know if that's easily possible. For now I've added the element property to the readme.

Yosh · Answer 3 · Sat May 30 2015 19:10:50 GMT+0800 (China Standard Time)

I can solve it for my own project by wrapping it in a custom element, which is a higher abstraction level. It does require a using a webcomponents polyfill, so I think it's better to have that live in a separate repo.