kangarko / Foundation

Foundation™ helps you create highly customized Minecraft plugins (based on Spigot/Paper API) that support multiple MC versions.

Home Page:https://mineacademy.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Foundation 6.3.4 : Method put(textures, com.mojang.authlib.properties.Property) Not Found

Ultimating opened this issue · comments

Hello,

I noticed in the latest Foundation that head textures are having trouble loading and it's because it can't find a method in Mojang AuthLib. Is there any way this can be fixed so that head textures can load again? Error exception is attached here from one of my testers. Thanks!

Exception

commented

@CoobMC Jack do I remember correctly you helped us with skulls API? If yes could you please look at the issue, looks like it needs updating to 1.19.4 thank you :)

commented

Hello

Based on my investigation, the problem seems to be related to changes in the getMethod() method after a specific commit.

In the previous code, this method only compared the method names. However, after the mentioned commit, it also compares the parameter types.
The PropertyMap#put(K key, V value) method's parameters are generic types, and they are changed to an "Object" type at runtime. As a result, the getMethod() method cannot find the put(String, Property) method, leading to an error.

To resolve this issue, it may be necessary to modify the getMethod() method to handle Generic types as well.

commented

You can just make a pull request thank you

commented

Should be fixed in the latest pull request thanks to @CoobMC