Snowpack support

Question

Snowpack support

KararTY opened this issue 3 years ago · comments

Does this module support browsers?

I'm specifically using it together with Snowpack (& Skypack CDN) to make it work on the browser but I get the following errors:

[23:33:25] [snowpack] + wikiapi@1.15.1
[23:33:26] [esinstall:wikiapi] Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\Wikiapi.js
   Import "./_CeL.loader.nodejs.js" could not be resolved from file.
[23:33:26] [esinstall:wikiapi] Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\Wikiapi.js
   Import "./_CeL.loader.nodejs.js" could not be resolved from file.
[23:33:26] [esinstall:wikiapi]  Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\_CeL.loader.nodejs.js?commonjs-external
   Module "Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\_CeL.loader.nodejs.js" could not be resolved by Snowpack (Is it installed?).
[23:33:26] [snowpack] Install failed.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This is how I import it:

import wikiapi from 'wikiapi'

kanasimi · Answer 1 · Fri Jun 04 2021 05:27:59 GMT+0800 (China Standard Time)

The module needs cejs. Do you also import cejs?

Karar Al-Remahy · Answer 2 · Fri Jun 04 2021 05:39:36 GMT+0800 (China Standard Time)

The module needs cejs. Do you also import cejs?

I've imported "cejs" but I still get the same issue:

[24:36:56] [snowpack] + wikiapi@1.15.1
[24:36:57] [esinstall:wikiapi] Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\Wikiapi.js
   Import "./_CeL.loader.nodejs.js" could not be resolved from file.
[24:36:57] [esinstall:wikiapi] Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\Wikiapi.js
   Import "./_CeL.loader.nodejs.js" could not be resolved from file.
[24:36:57] [esinstall:wikiapi]  Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\_CeL.loader.nodejs.js?commonjs-external
   Module "Home\DEV\ppsl-app-v1.5\node_modules\wikiapi\_CeL.loader.nodejs.js" could not be resolved by Snowpack (Is it installed?).
[24:36:57] [snowpack] Install failed.

kanasimi · Answer 3 · Fri Jun 04 2021 05:50:08 GMT+0800 (China Standard Time)

hmm... Do you have codes to test?

Karar Al-Remahy · Answer 4 · Fri Jun 04 2021 06:07:14 GMT+0800 (China Standard Time)

hmm... Do you have codes to test?

I've made a reproducible Github repository over here:
https://github.com/KararTY/wikiapi-test

Karar Al-Remahy · Answer 5 · Fri Jun 04 2021 18:14:59 GMT+0800 (China Standard Time)

This is still broken, I've updated https://github.com/KararTY/wikiapi-test

The new error I'm getting is:

cejs.v4.2.2.js:91 TypeError: fs.readFileSync is not a function
    at cejs.v4.2.2.js:55
    at cejs.v4.2.2.js:79
    at createCommonjsModule (cejs.v4.2.2.js:10)
    at cejs.v4.2.2.js:30
(anonymous) @ cejs.v4.2.2.js:91
createCommonjsModule @ cejs.v4.2.2.js:10
(anonymous) @ cejs.v4.2.2.js:30
wikiapi.v1.15.1.js:530 Uncaught TypeError: Cannot read property 'match' of undefined
    at wikiapi.v1.15.1.js:530
    at wikiapi.v1.15.1.js:643
    at createCommonjsModule (wikiapi.v1.15.1.js:239)
    at wikiapi.v1.15.1.js:509
(anonymous) @ wikiapi.v1.15.1.js:530
(anonymous) @ wikiapi.v1.15.1.js:643
createCommonjsModule @ wikiapi.v1.15.1.js:239
(anonymous) @ wikiapi.v1.15.1.js:509

Are you sure this module works in the browser? There's a lot of filesystem (fs) calls and module calls.

kanasimi · Answer 6 · Fri Jun 04 2021 20:00:31 GMT+0800 (China Standard Time)

This looks a bit complicated... still trying...

Karar Al-Remahy · Answer 7 · Fri Jun 04 2021 20:08:30 GMT+0800 (China Standard Time)

This looks a bit complicated... still trying...

What's the usual way of importing this module into the browser?

kanasimi · Answer 8 · Fri Jun 04 2021 20:11:09 GMT+0800 (China Standard Time)

It is a pure npm now. For browser, I using the method list in https://github.com/kanasimi/CeJS/tree/master/application/net/wiki#usage-in-mediawiki-user-script-userexamplecommonjs

kanasimi · Answer 9 · Sat Jun 05 2021 08:00:30 GMT+0800 (China Standard Time)

// Since Snowpack cannot read utf-8 or utf-16 script file now,
// you MUST create a web server, and set main_script_URL.
//window.CeL = { main_script_URL: 'https://localhost/path/to/ce.js' };
// Default URL to ce.js is https://kanasimi.github.io/CeJS/ce.js

import cejs from 'cejs';
cejs.then(CeL_module => import('wikiapi')).then(Wikiapi_module => main_process(Wikiapi_module.default));

async function main_process(Wikiapi) {
	const wiki = new Wikiapi({ project: 'en', origin: '*' });
	const page_data = await wiki.page('ABC');
	console.log(page_data);
}