Giters

kamranayub / UnderscoreKO

A tiny library that adds all of the Underscore.js collection/array methods to Knockout observable arrays

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bundle/Minification error with 1.2.2 version

dfaroi opened this issue · comments

commented

Hi,

After updating to last version (1.2.2), the bundling/minimizing with ASP.Net MVC 4 failed due to script header comment format.

To resolve this issue, i manually replace header comment with // instead of /* xxx */

Hope you will be able to fix it asap.

Thanks.

commented

Thanks, I'll take a look.

On Mon, Jan 28, 2013 at 2:28 AM, David Faroi notifications@github.comwrote:

Hi,

After updating to last version (1.2.2), the bundling/minimizing with
ASP.Net MVC 4 failed due to script header comment format.

To resolve this issue, i manually replace header comment with // instead
of /* xxx */

Hope you will be able to fix it asap.

Thanks.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7.

Kamran Ayub

commented

This will be fixed in the next update, thanks.

commented

Thanks.

commented

This is fixed in the latest ASP.NET Optimization Framework version (Tested with blank ASP.NET MVC 4 project with UKO 1.2.2 and optimization framework 1.1.3).

packages.config

<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="Antlr" version="3.4.1.9004" targetFramework="net40" />
  <package id="knockoutjs" version="2.2.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.Mvc" version="4.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.Mvc.FixedDisplayModes" version="1.0.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.Razor" version="2.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.Web.Optimization" version="1.1.3" targetFramework="net40" />
  <package id="Microsoft.AspNet.WebApi" version="4.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.WebApi.Client" version="4.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.WebApi.Core" version="4.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.WebApi.WebHost" version="4.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.AspNet.WebPages" version="2.0.30506.0" targetFramework="net40" />
  <package id="Microsoft.Net.Http" version="2.0.20710.0" targetFramework="net40" />
  <package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net40" />
  <package id="Newtonsoft.Json" version="5.0.4" targetFramework="net40" />
  <package id="underscore.js" version="1.2.2" targetFramework="net40" />
  <package id="UnderscoreKO" version="1.2.2" targetFramework="net40" />
  <package id="WebGrease" version="1.5.2" targetFramework="net40" />
</packages>