False positive: This statement seems to be disconnected from its parent foreach.

Question

False positive: This statement seems to be disconnected from its parent foreach.

inDeev opened this issue 6 months ago · comments

Subject	Details
Plugin	Php Inspections (EA Extended) 5.0.0.0
Language level	PHP 8.2

Current behaviour

Expected behaviour
No alert shown

Martin Eiber · Answer 1 · Mon Dec 18 2023 18:21:53 GMT+0800 (China Standard Time)

I had the same Issue. Reported here:
https://youtrack.jetbrains.com/issue/QD-7094/It-is-not-a-problem-EA-This-statement-seems-to-be-disconnected-from-its-parent-foreach.

Petr Kateřiňák (Inove) · Answer 2 · Mon Dec 18 2023 21:13:31 GMT+0800 (China Standard Time)

This EA looks too dificult for me. In my opinion it is almost not possible to know what exactly affects something out of foreach scope. This EA should be removed, I'm seeing it often and in some cases it helped to me, but in global perspective it has more false positives than true.

Vladimir Reznichenko · Answer 3 · Tue Dec 19 2023 00:53:53 GMT+0800 (China Standard Time)

@ea-inspections-team: this inspection is receiving a lot of complaints. Can you disable it by default in the next release please?

ea-inspections-team · Answer 4 · Sun Feb 04 2024 17:59:41 GMT+0800 (China Standard Time)

@kalessil: yes, we will disable it by default.

@inDeev: is addRow a part of any OSS package, or it is a proprietary code base? We would like to research a bit on false-positives vs pure/tinted methods and functions.

Petr Katerinak · Answer 5 · Sun Feb 04 2024 19:16:13 GMT+0800 (China Standard Time)

Hi, it is part of PHPWord package https://github.com/DerekMarcinyshyn/phpword/blob/master/samples/Sample_09_Tables.php