Nginx in sites-available/default ?

Question

Nginx in sites-available/default ?

JulienPalard opened this issue 10 years ago · comments

o/

On https://github.com/taigaio/taiga-scripts/blob/master/scripts/setup-nginx.sh#L84

Your writing your configuration file in sites-available/default, it may be dangerous, someone may have changed this file, you may use site-available/taiga instead.

Bests,

Andrey Antukh · Answer 1 · Thu Oct 02 2014 23:07:44 GMT+0800 (China Standard Time)

Hi @JulienPalard
Yes, it can be dangerous, but this script is intended to use in fresh ubuntu 14.04 installation image.

Julien Palard · Answer 2 · Thu Oct 02 2014 23:19:32 GMT+0800 (China Standard Time)

Oh I used it on a test machine (Debian jessie), not fresh at all, but fortunately we don't use sites-available/default ;-)

You may probably still change it ?

Andrey Antukh · Answer 3 · Thu Oct 02 2014 23:21:32 GMT+0800 (China Standard Time)

I will consider this change obviously, safer settings are always better. But at this moment is not very priority change, sorry. I'll keep this issue open until I have changed it.

Thanks

Julien Palard · Answer 4 · Thu Oct 02 2014 23:24:25 GMT+0800 (China Standard Time)

Cool for me, good day to you !

Rafael Nascimento Sampaio · Answer 5 · Tue Dec 02 2014 23:35:02 GMT+0800 (China Standard Time)

I believe that this issue is already fixed with the commit 3f0fe9f.

Alejandro · Answer 6 · Wed Dec 03 2014 17:52:47 GMT+0800 (China Standard Time)

@niwibe could you confirm this, please?

Andrey Antukh · Answer 7 · Wed Dec 03 2014 17:55:24 GMT+0800 (China Standard Time)

You are right @ooredroxoo . I completely forgot to close this issue.