Giters

kalcifer / ember-dragula

Simple drag and drop with dragula and ember

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecation with using component lifecycle hook arguments

begedin opened this issue · comments

commented

There is a new deprecation in using component lifecycle hook arguments:

https://emberjs.com/deprecations/v2.x/#toc_arguments-in-component-lifecycle-hooks

As far as I can tell, the only issue is in

https://github.com/kalcifer/ember-dragula/blob/master/addon/components/ember-dragula-container.js#L11

This should be rewritten to either not use oldAttrs at all, or arguments should be deconstructed to get the value of oldAttrs.

commented

I'm not sure how to test the didUpdateAttrs method there.

Normal drag/drop seems to continue to work without it? @pksjce any ideas?