kahole / edamagit

Magit for VSCode

Home Page:https://marketplace.visualstudio.com/items?itemName=kahole.magit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Enable in untrusted workspaces?

The-Compiler opened this issue · comments

With VS Code 1.57, Workspace Trust was introduced.

edamagit doesn't seem to declare support for running on untrusted workspaces, so it gets disabled when opening an untrusted folder.

I'm wondering if it'd be safe to enable edamagit no matter what the workspace contents are? I'm guessing running git on untrusted projects should be fine, but not sure what else edamagit is doing exactly. See microsoft/vscode#120251 for some more context.

As a workaround, doing

    "extensions.supportUntrustedWorkspaces": {
        "kahole.magit": { "supported": true },
    },

in settings.json should enable the extension again, though I haven't actually tested (as I'm not sure if it should be running in untrusted workspaces really).

I'm not all that familiar with this concept yet. But running edamagit is not that different from running git. For the most part, it runs git commands underneath.

v0.6.17 has support for untrusted workspaces. Thanks for reporting this