Sprites scale awkwardly with windows scale settings.
whistler-1 opened this issue · comments
Description of the bug & expected behaviour
When scale is set to 150% in Windows 10 sprites will scale up accordingly but in a way that messes up the spritework. Ideally sprites shouldn't be sized up in a way that makes them look "crunchy" like this, maybe only resize them at intervals of 1x, 2x, 3x etc?
You can see here that some lines become really thick and some stay 1px wide:
Environment Info
- OS: Windows 10 Education 21H2
- JetBrains Product: IntelliJ Ultimate
- JetBrains Product Version: 2023.2.1
- Plugin Version: 2.1.1
Steps to reproduce
- In display settings, set "Scale and Layout" to 150%
- Open pokemon progress settings in IntelliJ to see the sprites.
Hi @whistler-1, really sorry for sucha delayed reply to this ticket. Due to the nature of pixel art, scaling up by a non-whole number will necessarily cause those sorts of chunky artifacts, as you've pointed out.
I'm thinking the following might work, based somewhat on this Stackoverflow answer:
- in the
paint
method get theWindow
of theComponent
- from the
Window
get thescaleX
andscaleY
of theGraphicsConfiguration
- call
.scale(Math.round(scaleX) / scaleX, Math.round(scaleY) / scaleY)
on theGraphics2D
object which should then result in the scale being rounded to the nearest integer value
I'm not at all familiar with how Windows scaling works under the hood or how it interacts with Java so I might be mistaken about the above, but it seems promising to me, and worth a try. Does it seems reasonable to you, or am I missing something obvious?
If it work, this could easily be made another configurable option, something like "force integer dispay scaling".