kagof / intellij-pokemon-progress

A Pokémon themed progress bar for IntelliJ IDEA.

Home Page:https://plugins.jetbrains.com/plugin/15090-pokemon-progress

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Sprites do not appear on a Retina display

kagof opened this issue · comments

Description of the bug & expected behaviour (required)

When I have the IntelliJ window open on a side monitor, icons display as usual. When I have it open on my Macbook Pro's built in screen (a Retina screen), the fill shows up, but the Pokémon sprite does not.

Environment Info (required)

  • OS: Mac OSX Catalina
  • JetBrains Product: IntelliJ Ultimate
  • JetBrains Product Version: 2020.2.2
  • Plugin Version: 1.0.0

Steps to reproduce (optional)

  1. Open IntelliJ window on a Retina screen
  2. Trigger a progress bar

Additional context or information (optional)

This likely is related to how IntelliJ processes icons on a Retina display, see the documentation. Gifs are not mentioned there, but I think it is safe to assume that I need to create the iconName@2x.gif files in order for this to work properly

I've confirmed that adding the @2x gifs fixes the issue, and edited the editSprite.sh script to create these for all future gifs. I've done the @2x gif creation for all gifs that did not need to be resized from their original png's size, but the hard part now is updating the ones that did need their sizes tweaks, as I don't remember or have record of how much they were tweaked by. I think this will be an annoyingly manual migration process.