Massive perf boost if we enable ReleaseOnCancel for LE
martinkennelly opened this issue · comments
During testing, I see a great perf boost if we enable ReleaseOnCancel for LE.
I think, its a good idea to enable this feature. We only cancel LE context after we are finished operations on the data that the lease is protecting.
3 node master + 30 workers.
Right now with current master:
Number of pods 1200: All created: 137m
With ReleaseOnCancel enabled + PR #142:
Number of pods 1200: All created: 3m25s, All deleted: 7m56s
Number of pods 2400: All created: 17m49s, All deleted: 21m27s
Number of pods 3000: All created: 26m, All deleted: 31m
@rthakur-est can you replicate this? (you can use this)
3 node master + 30 workers.
Right now with current master:
Number of pods 1200: All created: 137mWith ReleaseOnCancel enabled + PR #142:
Number of pods 1200: All created: 3m25s, All deleted: 7m56s
Number of pods 2400: All created: 17m49s, All deleted: 21m27s
Number of pods 3000: All created: 26m, All deleted: 31m@rthakur-est can you replicate this? (you can use this)
I will ask my team to try this. Where is the change for ReleaseOnCancel for LE?
See here: #145