Daemonst SR-IOV network-config-daemon is not deleted
cyclinder opened this issue · comments
Steps to reproduce:
- deploy SR-IOV Network Operator using helm chart
- uninstall SR-IOV Network Operator
and I found Daemonst SR-IOV network-config-daemon is not deleted, all resources of SR-IOV should be clean up.
➜ spiderpool git:(spidercoorinator/kubeadm_config) ✗ kubectl get po -n kube-system
NAME READY STATUS RESTARTS AGE
coredns-5d78c9869d-r24pv 1/1 Running 3 22d
coredns-5d78c9869d-r66rn 1/1 Running 3 (20d ago) 22d
etcd-kind-control-plane 1/1 Running 6 22d
kindnet-czntv 1/1 Running 13 (20d ago) 22d
kindnet-jp8lt 1/1 Running 10 (20d ago) 22d
kindnet-tdr6w 1/1 Running 14 (20d ago) 22d
kube-apiserver-kind-control-plane 1/1 Running 11 (20d ago) 22d
kube-controller-manager-kind-control-plane 1/1 Running 0 5h58m
kube-proxy-96q5x 1/1 Running 0 22d
kube-proxy-hgxfj 1/1 Running 0 22d
kube-proxy-ndwhw 1/1 Running 0 22d
kube-scheduler-kind-control-plane 1/1 Running 15 (20h ago) 22d
sriov-network-config-daemon-k4m7d 3/3 Running 0 2d2h
sriov-network-config-daemon-lhdqf 3/3 Running 0 2d2h
I think some of the rework here #556 will take care of this
Can you reproduce this issue with latest master? I suspect this PR could have solved it
SriovOperatorConfig, which is the config-daemon owner reference, is now part of the helm deployment, so it should be removed by the uninstall procedure.
@zeeke sure, I will reproduce this issue with latest master in my free time. and if it can be solved, can we have a new release? I see it's been a long time since the last release.
the test results are good!
root@10-20-1-20:/home/cyclinder/sriov-network-operator/deployment/sriov-network-operator# kubectl get po -n kube-system
NAME READY STATUS RESTARTS AGE
coredns-7ddf9b46c6-tm6d6 1/1 Running 6 (20d ago) 30d
coredns-7ddf9b46c6-xsqqq 1/1 Running 6 (20d ago) 30d
etcd-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kindnet-7fc8v 1/1 Running 6 (20d ago) 30d
kindnet-fbm5p 1/1 Running 6 (20d ago) 30d
kube-apiserver-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kube-controller-manager-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kube-proxy-qd8z8 1/1 Running 6 (20d ago) 30d
kube-proxy-wtw9k 1/1 Running 6 (20d ago) 30d
kube-scheduler-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
sriov-network-config-daemon-7x59j 1/1 Running 0 46m
sriov-network-config-daemon-bzwvs 1/1 Running 0 46m
sriov-operator-sriov-network-operator-65cbfd4876-2bwrw 1/1 Running 0 3h28m
root@10-20-1-20:/home/cyclinder/sriov-network-operator/deployment/sriov-network-operator# kubectl ^C
root@10-20-1-20:/home/cyclinder/sriov-network-operator/deployment/sriov-network-operator# helm uninstall sriov-operator -n kube-system
release "sriov-operator" uninstalled
root@10-20-1-20:/home/cyclinder/sriov-network-operator/deployment/sriov-network-operator# kubectl get po -n kube-system
NAME READY STATUS RESTARTS AGE
coredns-7ddf9b46c6-tm6d6 1/1 Running 6 (20d ago) 30d
coredns-7ddf9b46c6-xsqqq 1/1 Running 6 (20d ago) 30d
etcd-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kindnet-7fc8v 1/1 Running 6 (20d ago) 30d
kindnet-fbm5p 1/1 Running 6 (20d ago) 30d
kube-apiserver-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kube-controller-manager-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
kube-proxy-qd8z8 1/1 Running 6 (20d ago) 30d
kube-proxy-wtw9k 1/1 Running 6 (20d ago) 30d
kube-scheduler-k8s-dra-driver-cluster-control-plane 1/1 Running 6 (20d ago) 30d
Great! I'll close this as soon as we release this fix