extended cli not working on linux (with solution)

Question

extended cli not working on linux (with solution)

devcpu opened this issue 4 years ago · comments

All extended cli command are not working on linux because of the different lineend (\r vs. \n).
In function cli_extended_commands (line ~ 12884)

please change

if (incoming_serial_byte == 13) {   // carriage return - get out

to

if (incoming_serial_byte == 13 || incoming_serial_byte == 10) {   // carriage return - get out

that's it.

Can't make a pull request, but it is quite simple.

BTW. Many thanks for the software.
73 de DL7UXA

Anthony Good · Answer 1 · Sun Jul 26 2020 06:17:39 GMT+0800 (China Standard Time)

What terminal program are you using?

…

On Sat, Jul 25, 2020 at 6:06 PM Johannes Arlt ***@***.***> wrote: All extended cli command are not working on linux because of the different lineend (\r vs. \n). In function cli_extended_commands (line ~ 12884) please change if (incoming_serial_byte == 13) { // carriage return - get out to if (incoming_serial_byte == 13 || incoming_serial_byte == 10) { // carriage return - get out that's it. Can't make a pull request, but it is quite simple. BTW. Many thanks for the software. 73 de DL7UXA — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNU4EVAFVNR6JK6OFG3BTR5NJNTANCNFSM4PHU7Q4A> .

Johannes Arlt · Answer 2 · Sun Jul 26 2020 09:14:52 GMT+0800 (China Standard Time)

The terminal in arduino ide.
I found a lot of similar code. Some check of 10 and 13, some not. I see this because same problem programing memories from CLI.

Anthony Good · Answer 3 · Sun Jul 26 2020 09:18:30 GMT+0800 (China Standard Time)

Have you tried to set your Arduino IDE terminal to "Carriage Return" using the control at the bottom of the window?

…

On Sat, Jul 25, 2020 at 9:15 PM Johannes Arlt ***@***.***> wrote: The terminal in arduino ide. I found a lot of similar code. Some check of 10 and 13, some not. I see this because same problem programing memories from CLI. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNU4A5FF2NPBP76NWVL4DR5N7RPANCNFSM4PHU7Q4A> .

tuxun · Answer 4 · Sun Jul 26 2020 18:00:27 GMT+0800 (China Standard Time)

It think its strange cause windows end of line should be "\r\n" and the unix one "\n". https://stackoverflow.com/questions/1761051/difference-between-n-and-r
please correct me if I"m wrong

Anthony Good · Answer 5 · Mon Jul 27 2020 03:47:45 GMT+0800 (China Standard Time)

Fixed in version 2020.07.26.01

Thanks!
73
Goody
K3NG