jychoi118 / ilvr_adm

ILVR: Conditioning Method for Denoising Diffusion Probabilistic Models (ICCV 2021 Oral)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Possible errors about using q_sample(x, t)

ZGCTroy opened this issue · comments

image
Thanks for your impressive contribution !
You implemented y_{t-1} by using the method q_sample(y, t). However, the right way is q_sample(y, t-1). Is there exisits any errors here?
image

Yes, t should be modified to t-1. Thank you for letting me know the error.

While the experiments in the paper were done correctly with t-1, I made a mistake while moving to the guided-diffusion codebase.

In fact, the mistakenly added noise (variance \beta_t) is small enough to be eliminated by downsampling operation, thus the samples are fine even with t.

Thanks for your reply. I agree with you that "the mistakenly added noise (variance \beta_t) is small enough to be eliminated by downsampling operation, thus the samples are fine even with t".