jwoudenberg / elm-pair

An artificial pair-programmer that helps you write Elm

Home Page:https://elm-pair.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mac M1 binaries (aarch64-darwin)

Janiczek opened this issue · comments

It would be nice if the tool could download the M1 version of elm-pair automatically or if we could download it from the GitHub releases.

FWIW I've been able to nix build elm-pair on M1 and get aarch64 binaries after changing flake.nix in this way:

-    let supportedSystems = [ "x86_64-linux" "x86_64-darwin" ];
+    let supportedSystems = [ "x86_64-linux" "x86_64-darwin" "aarch64-darwin" ];

I added this to the flake.nix on master. I should have a new release later today. Let me know if that works for you.

Out of interest, have you been using the patch above for longer, or were you previously running the x86_64-darwin binaries using rosetta?

I previously ran into some trouble trying to compile aarch64-darwin binaries using the github workflow, but maybe should give that another try. I've been assuming the x86_64-darwin binaries would work on M1 Mac's too because of Rosetta, but I imagine having aarch64-darwin binaries is a better experience? Don't have the hardware to test this myself.

Thank you for surfacing this!

I was using x86_64-darwin binaries via Rosetta until yesterday. They work fine! (Provided you have Rosetta 2 installed, which is a reasonable requirement for dev tooling)

It will probably be more efficient / performant, but other than that I don't expect to find any difference between the two builds :)

Good to know, thank you!

In that case I'm going to leave things with the flake.nix change for now. I'm keeping this issue open because I want to make an aarch64-darwin downloadable binary available at some point too, but it's not a priority for me at the moment because the x86_64-darwin binary works on M1's too in combination with Rosetta 2. If that's problematic for anyone reading this, please let me know and I might reprioritize!