tslint as peer

Question

tslint as peer

bookman25 opened this issue 7 years ago · comments

Bryan Nicholls commented 7 years ago

Should make tslint a peer dependency

jwbay · Answer 1 · Thu Mar 02 2017 07:21:06 GMT+0800 (China Standard Time)

Why? We import it and use its APIs directly.

Bryan Nicholls · Answer 2 · Thu Mar 02 2017 08:56:49 GMT+0800 (China Standard Time)

I was just looking at: https://github.com/buzinas/tslint-eslint-rules/blob/master/CHANGELOG.md and thinking it was kind of nice. And based off this: https://nodejs.org/en/blog/npm/peer-dependencies/ it seems like peer dependencies are correct for plugins

jwbay · Answer 3 · Thu Mar 02 2017 10:33:58 GMT+0800 (China Standard Time)

Peer deps are meant for packages that don't do an explicit require( of the dependency. That's mentioned in both the docs for peer deps and the linked article. That's common for lots of plugin systems and the reason peer deps were added in the first place, but this doesn't apply to tslint rules. Even when the article makes a case for explicitly required dependencies being peers, it's in the context of restrictive version ranges.