juxt / bidi

Bidirectional URI routing

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bidi brings older version of `ring-core` into projects; should it be :scope "provided"?

timothypratley opened this issue · comments

Including bidi as a dependency can break handlers that are expecting a higher version of ring-core:
taoensso/sente#322

Should the ring-core dependency be :scope "provided" to avoid this?

For setting the scope to provided in leiningen, a profile is preferred (https://github.com/technomancy/leiningen/blob/master/doc/PROFILES.md#default-profiles mentions this briefly).

I agree ring-core should be in :provided scope, as it's not necessary in order to use bidi at all.