justmoon / relative-numbers

Relative line numbers package for Atom

Home Page:https://atom.io/packages/relative-numbers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HTMLElement.rootElement is deprecated. - Stable

heftyfunseeker opened this issue · comments

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using rootElement and access
the editor contents directly instead.

HTMLElement.rootElement (C:\Users\Nicco\AppData\Local\atom\app-1.19.0-beta7\resources\app\src\text-editor-element.js:23:10)
LineNumberView._updateSync (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:101:50)
_updateSync (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:3:59)
<unknown> (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:83:26)
ViewRegistry.performDocumentUpdate (<embedded>:20098:15)
<unknown> (<embedded>:19914:65)

Is this plug-in still in maintenance

commented

the fix was merged to master, but the release is yet to come. you can apply it on your own for now:
https://github.com/justmoon/relative-numbers/pull/40/files

hy not release?

Thank you. The original question has been settled!
But why isn't there a new version?

@justmoon A new version would help us 🙂.

@binarious @linjialiang while the author figures things out i've published the fix in a new package

https://atom.io/packages/relative-numbers-plus

@Mike3run It would be helpful if you explained what the difference was in the readme for your relative-numbers-plus package. I just installed relative-numbers and saw yours in the list but had no idea what the difference was.

@Aventura5 i dun goofed, lol what I did is grab the PR request the are talking about and published that, but it didn't work, i guess it has other breaking changes we are not aware of so for now you're better off applying this manually on the normal package installation:

https://github.com/justmoon/relative-numbers/pull/40/files

Hey @justmoon - could you please produce a new release for this? If you haven't got the bandwidth to do it, maybe you could ask for a volunteer to help maintain the package?

Soooooo new version ?

lol its clearly not gonna happen (specially now on December...) you're better off either:

Upgrade to 0.8.1. Apologies for the delay, I thought I had bumped the version but apparently not.