Giters

justjanne / powerline-go

A beautiful and useful low-latency prompt for your shell, written in go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Git staged tick is rendering grey, not white

jamieburchell opened this issue · comments

commented

Describe the bug
Git staged tick is rendering grey, not white

Screenshot 2023-01-16 134215

To Reproduce
Install latest version of powerline-go and Cascadia Code 2111.01 (Cascadia Code PL)

Expected behavior
Tick should be white

Environment (please complete the following information):

  • OS: Windows 11 / WSL
  • Shell: Bash

Additional context
Using Windows Terminal Preview 1.16.3464.0

commented

That looks like a bug in Windows Terminal instead, the color is set to white and the character should be rendered as regular character. Windows Terminal seems to render it as emoji instead.

commented

@justjanne Apologies, I didn't know which component was causing the problem. It's possible that this has happened as a result of switching to Terminal Preview (from regular Terminal) for a feature I wanted.

commented

But no matter which component causes the issue, we should look into a way to fix it. Potentially adding a U+FE0E variation selector might already be enough to fix it.

commented

Potentially adding a U+FE0E variation selector might already be enough to fix it.

@justjanne, that visually works, but has (recently) started causing some major issues on my end.

In order to remedy some half-width emojis in my "WSL2/Ubuntu/Windows Terminal (Preview)"-setup, I added the following to the configuration some time ago:

"Modes": {
  "patched": {
    "Lock": "\uE0A2\uFE0E",
    "Network": "\u260E\uFE0E",
    "RepoBranch": "\uE0A0\uFE0E",
    "RepoDetached": "\u2693\uFE0E",
    "RepoAhead": "\u2B06\uFE0E",
    "RepoBehind": "\u2B07\uFE0E",
    "RepoConflicted": "\u273C\uFE0E",
    "RepoStashed": "\u2691\uFE0E",
    "RepoNotStaged": "\u270E\uFE0E",
    "RepoStaged": "\u2714\uFE0E"
  }
}

This works like a charm on Ubuntu 20.04 (with bash 5.0.17). After recently upgrading a couple machines to Ubuntu 22.04 (bash 5.2.2) it started to become problematic though: When copy-pasting text onto the terminal or scrolling through history (arrow-key up/down) input becomes totally garbled.

It appears that for every "\uFE0E-emoji" on the prompt, two spaces are "lost". It's most obvious when copy-pasting something: Paste, press left arrow-key once, the entire input on the prompt moves two spaces to the left (and leaves the last two characters duplicated at the end). After this point input is "broken"; what's shown on the screen is not actually what's there any more...

Removing \uFE0E from the above configuration, or navigating to a folder that doesn't have any emojis on its prompt, resolves the issue.

I haven't had the time/opportunity to dig any deeper, so I'm not entirely what's causing it (outside of the Ubuntu upgrade)...

commented

This is still an issue using v1.24 on Windows Terminal Preview Version 1.18.1462.0 and Ubuntu 22.04.2

commented

Any update on this @justjanne ?