VirtualFish 2.2.4 warns about requiring fish 3.3.0

[Fabio Sangiovanni]

• I am using Fish shell version 3.1 or higher.
• I am using Python version 3.6 or higher.
• I have searched the issues (including closed ones) and believe that this is not a duplicate.

• OS version and name: MacOS 10.15.4
• Fish shell version: 3.1.2
• VirtualFish version: 2.2.4

Issue

Hi, and thanks for maintaining VirtualFish.

I upgraded to 2.2.4 this morning and got this warning:

WARNING: VirtualFish requires Fish 3.3.0 or higher. Current version: 3.1.2

but there's no fish 3.3.0 yet, so I think something's wrong with version checks.

I hope this report will be useful, please let me know if you need further information.

Fabio

[Justin Mayer]

Many thanks for reporting this, Fabio. I clearly did not have enough coffee yesterday when I left that fictitious version number in there, which I had only added during testing to ensure that the functionality actually worked. 🤦

I fixed it via cee9e2f and just released VirtualFish 2.2.5 containing that fix (and a few other improvements).

Thanks also for the kind words. It is thoughtful comments like yours that make maintaining open source projects worth it. You rock! 😁

[Fabio Sangiovanni]

Glad to be helpful!
"So long, and thanks for all the virtualfish"