vf globalpackages uses deprecated mechanism
airwoodix opened this issue · comments
vf globalpackages currently uses the no-global-site-packages.txt flag file to disable global site packages. This is depracted in favor of the include-system-site-packages option in pyvenv.cfg. (PEP405). The old version doesn't work on newer virtualenv versions. virtualfish should at least support the newer mechanism to not break on newer environments.
Hi Etienne. Thank you for the helpful information. I can honestly say I have never once used the vf globalpackages command and forgot it existed. Would you be willing to lend a hand and submit a pull request to address the changes you suggested? I could really use the assistance.
This might also be a good occasion to document the command's existence in the command reference section. Otherwise, folks won't even know that command exists without running vf help.
Thanks for the feedback @justinmayer. Did you already get a chance to look at #173?
@airwoodix: I did, yes, and I left a review with some minor suggestions over on that PR. Do you have any questions about my comments? If so, please feel free to respond over in that PR's review thread.