loading.js

Question

loading.js

fds39 opened this issue 4 years ago · comments

I had to remove this hook which crashed the latest snapshot 3.5.2131.8 (Official version) (64 bits)
https://forum.vivaldi.net/post/428015

guigirl42 · Answer 1 · Wed Dec 16 2020 14:38:50 GMT+0800 (China Standard Time)

Same here.
https://forum.vivaldi.net/post/428029

Denis Porfiryev · Answer 2 · Wed Dec 16 2020 17:46:41 GMT+0800 (China Standard Time)

Yeah. Need to redisign require function.

Denis Porfiryev · Answer 3 · Thu Dec 17 2020 16:00:58 GMT+0800 (China Standard Time)

commit 208da9f

guigirl42 · Answer 4 · Thu Dec 17 2020 17:58:21 GMT+0800 (China Standard Time)

Thank you. Now loading.js no longer crashes Snapshot 3.5.2131.8 / Chrome 87.0.4280.88, but another of your newly updated hooks, bookmarks-button.js, seems to be broken. It crashes Stable, & whilst Snapshot launches with it, once activated it does nothing when the icon is clicked. Pls see my post: https://forum.vivaldi.net/post/428847

Denis Porfiryev · Answer 5 · Thu Dec 17 2020 18:34:14 GMT+0800 (China Standard Time)

I'm sorry I cannot reproduce it. The only issue I experience is issue #53: selected mode is not displayed in configuration until I click a radiobutton. bookmarks-button.js may be used in 2 modes, are you sure you're trying using the one you have configured?

Denis Porfiryev · Answer 6 · Thu Dec 17 2020 20:01:52 GMT+0800 (China Standard Time)

As loading.js is fixed I'm closing this issue. If you have more details about reproducing the bug please submit a new one.