nav_external_links > opens_in_new_tab: true doesn't open the link in a new tab

Question

nav_external_links > opens_in_new_tab: true doesn't open the link in a new tab

p-bakker opened this issue 8 months ago · comments

Paul Bakker commented 8 months ago

Describe the bug
As the title says, see setup here: https://github.com/rhino/rhino.github.io

To Reproduce
Steps to reproduce the behavior:

Go to https://rhino.github.io/
Click on 'Kangax's Compat Table'
Notice that it opens in the current tab, instead of a new tab

Expected behavior
Opens the link in a new tab

Paul Bakker · Answer 1 · Fri Oct 06 2023 00:28:58 GMT+0800 (China Standard Time)

Or did I mistakenly assumed this to be included in 0.6.2 already?

I found the setting in https://just-the-docs.com/docs/navigation-structure/#external-navigation-links, but based on the change log it seems it only got added after 0.6.2, in #1360?

CarbonNeuron · Answer 2 · Fri Oct 06 2023 01:00:42 GMT+0800 (China Standard Time)

Yeah that pull request was just merged less than 24 hours ago. Probably won't be added until next update.

Matt Wang · Answer 3 · Fri Oct 06 2023 01:13:04 GMT+0800 (China Standard Time)

Yup, this is an unreleased feature; note the warning on the homepage

This website documents the features of the current main branch of the Just the Docs theme. See the CHANGELOG for a list of releases, new features, and bug fixes.

I was in the process of adding a tag for the version. I'll merge in #1363, which makes this more clear.

Matt Wang · Answer 4 · Fri Oct 06 2023 01:14:08 GMT+0800 (China Standard Time)

I'm waiting on ~ 1 in-flight PR before we cut a new release. I'm going to close this issue for now, but feel free to re-open if you have other questions!