jupyterlab / jupyterlab

JupyterLab computational environment.

Home Page:https://jupyterlab.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Resetting a shortcut does not restore and enable the default if it was modified

RRosio opened this issue · comments

Description

I have tried updating the shortcuts, whether I add a new shortcut in addition to an existing one or I modify the single provided shortcut, there are times where the shortcut disappears entirely and if I visit the user-settings shortcuts.jupyterlab-settings config file I can see it is disabled.

shortcuts_disabled.mov

Reproduce

  1. Go to 'Settings'
  2. Select 'Settings Editor'
  3. Select the 'Keyboard Shortcuts' from the left menu.
  4. Modify a shortcut and accept changes
  5. Reset the shortcut (steps 4-5 may need to be repeated multiple times)
  6. At some point, the shortcut will disappear from the list displayed.
  7. See the 'user-settings' shortcuts.jupyterlab-settings and see the shortcut now has the "disabled": true property

Expected behavior

I would expect that the shortcut, when reset, goes back to it's initial values.

Context

  • Operating System and version: M1 macOS 3.6.1 (22G313)
  • Browser and version: 123.0.6312.87 (Official Build) (arm64)
  • JupyterLab version: 4.2.0

The "disabled" entry is added when you modify the default shortcut (it is a two step process - "disable" the default shortcut, add a new shortcut). The issue is that when you click "Reset", it removes the new shortcut but does not enable the default shortcutback. I will rename the issue to reflect this.