jupyter / nbformat

Reference implementation of the Jupyter Notebook format

Home Page:http://nbformat.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should normalize update minor_version?

vidartf opened this issue · comments

Currently if I run a v 4.0 notebook through nbformat.validator.normalize, it will add cell ids, but it will leave the minor version as 0. Shouldn't it be updated to 5 to highlight that it now includes some fields that was added in that version of the schema? Since the previous versions have the schema with additionalProperties: false, the new notebook will be invalid against the 4.0 schema.

Yes, it makes sense to me that whenever a normalize occurs, it should bump to the version that was used to normalize.