add ntopng.conf ?

Question

add ntopng.conf ?

ShagoY opened this issue 5 years ago · comments

First of all, thank you for this ntopng docker version!

I would like to add the file ntopng.conf "out of the box" without making any modifications (build, etc...), is it possible?

Regards.

ShagoY · Answer 1 · Thu Mar 07 2019 22:21:03 GMT+0800 (China Standard Time)

Like 54f19b6

Javier Junquera Sánchez · Answer 2 · Fri Mar 08 2019 16:56:33 GMT+0800 (China Standard Time)

Of course! Sincerely I have ever used any "aditional option", and I never would have thought it.

Thank you!

Javier Junquera Sánchez · Answer 3 · Fri Mar 08 2019 16:59:30 GMT+0800 (China Standard Time)

Would you like to make the pull request?

ShagoY · Answer 4 · Fri Mar 08 2019 21:42:46 GMT+0800 (China Standard Time)

docker-compose.yml :

version: '3.2'
services:  
    ntopng:
        image: junquera/ntopng
        container_name: ntopng
        restart: unless-stopped
        network_mode: host
        volumes:
        - ./ntopng.conf:/ntop/ntopng.conf:ro
        environment:
        - CONFIG=/ntop/ntopng.conf

Or
docker run --net=host -t -p 3000:3000 -e CONFIG=/ntop/ntopng.conf -v ./ntopng.conf:/ntop/ntopng.conf:ro junquera/ntopng

ShagoY · Answer 5 · Fri Mar 08 2019 21:53:29 GMT+0800 (China Standard Time)

ntopng.conf
https://www.ntop.org/guides/ntopng/how_to_start/configuration_file.html#
And
https://www.ntop.org/guides/ntopng/cli_options.html

Javier Junquera Sánchez · Answer 6 · Sat Mar 09 2019 04:03:31 GMT+0800 (China Standard Time)

Hi @ShagoY! I don't really understand what have you done, there are a lot of changes (some in the issue and some others in the pull request), but I've detected that you have worked based in an old commit. Please, pull the latest master changes and integrate your changes there. Then pull request again.

Personally I prefer this way in your issue comments:

# start.sh
 cd /ntop/ntopng && ./ntopng "$@"

than this other in your PR:

 cd /ntop/ntopng && ./ntopng $CONFIG

If you have any doubt or you prefer me to do it, feel free of tell me, but I would like to see this commits with your name: it's your work and your idea!

ShagoY · Answer 7 · Sat Mar 09 2019 07:26:37 GMT+0800 (China Standard Time)

I don't know why I was on an old commit.... btw i made the Pull request again and it's ok with docker cloud.

"$@" uses the tag "cmd" (cmd line and docker-compose) but if you do a "ps aux", you will notice that the cmd is also added to start.sh script.

However, if you use the environment variables ($CONFIG), they are only added to ./ntopng

So it's a design choice, I guess....

Javier Junquera Sánchez · Answer 8 · Sat Mar 09 2019 22:10:52 GMT+0800 (China Standard Time)

Perfect! Do you wanna add the docker-compose file to the PR or is it ok?

ShagoY · Answer 9 · Sat Mar 09 2019 22:46:51 GMT+0800 (China Standard Time)

I have no opinion on that.

I think adding the possibility to use this variable directly in the "readme" may be enough.

In addition, the variable can be used in different ways:

docker run --net=host -e CONFIG=/ntop/ntopng.conf -v./ntopng.conf:/ntop/ntopng.conf:/ntop/ntopng.conf:ro junquera/ntopng

Or

docker run --net=host -e CONFIG="-i=eth1 -w=3000 -n=1" junquera/ntopng

Javier Junquera Sánchez · Answer 10 · Sat Mar 09 2019 23:16:20 GMT+0800 (China Standard Time)

I'll add it then with the two links you told. I think it could be usefull for many people.

Tonight (in Spain, in about five hours) I merge your code! 😉

ShagoY · Answer 11 · Sun Mar 10 2019 00:07:01 GMT+0800 (China Standard Time)

Excellent! I am a neighbour from France ;-)

Javier Junquera Sánchez · Answer 12 · Sun Mar 10 2019 06:04:15 GMT+0800 (China Standard Time)

Done! Thank you very much! Merci! 😄