jumbojett / OpenID-Connect-PHP

Minimalist OpenID Connect client

Home Page:https://github.com/jumbojett/OpenID-Connect-PHP

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SERVER_PORT always causes port in redirect URL

timsmid opened this issue · comments

When $_SERVER['SERVER_PORT'] is set, the getRedirectUrl method always includes a port number, even when the port is 80 or 443. This is caused by comparing a string ($_SERVER['SERVER_PORT']) with an integer (80 and 443).

I will submit a PR to resolve this issue.

@timsmid thank you for this, after upgrading to 1.0.0 we couldn't log in with Okta due to redirect URI mismatch so adding :443 to the allowed URL's in Okta allowed us to work around this bug until your PR is merged.

Any news on this topic? We're facing this bug as well

PR merged -> close