jumbojett / OpenID-Connect-PHP

Minimalist OpenID Connect client

Home Page:https://github.com/jumbojett/OpenID-Connect-PHP

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

php-xml dependency

mrvanes opened this issue · comments

I raised the issue of phpseclib php-xml dependency with the maintainer of phpseclib because OpenID-Connect-PHP fails if php-xml isn't installed, but his answer is that it's such an obscure use case that it's not his intention to make php-xml a hard dependency.
He is, however thinking about implementing a native jwks processor.

  1. Could you make php-xml a hard dependency og OpenID-Connect-PHP to make it easier to spot problems before they occur when using OpenID-Connect-PHP and
  2. Maybe it's worthwile following phpseclibs progress on native support for jwks keys instead of wrapping them in an xml document?

phpseclib/phpseclib#1817

Should be fixed with suggestions on #327

I will incorporate this

commented

Yesterday was the second time I banged my head into this issue. When is the native support for JSON webkeys planned land or php-xml be a hard dependency? Is it still waiting for a 1.xx release?

taken care of with #327