Solve Play 2.5 version conflicts

[Gabor Fulop]

Version 2.0.0 supports both Play 2.4 and Play 2.5 but in plugins.sbt Play 2.4 is used.
That couse version conflicts during sbt's dependency resolving:

[warn]  * com.typesafe.play:play_2.11:2.5.18 is selected over 2.4.0
[warn]      +- com.typesafe.play:play-cache_2.11:2.5.18           (depends on 2.5.18)
[warn]      +- com.typesafe.play:play-jdbc-api_2.11:2.5.18        (depends on 2.5.18)
[warn]      +- com.typesafe.play:play-logback_2.11:2.5.18         (depends on 2.5.18)
[warn]      +- com.typesafe.play:play-ws_2.11:2.5.18              (depends on 2.5.18)
[warn]      +- com.typesafe.play:play-server_2.11:2.5.18          (depends on 2.5.18)
[warn]      +- org.julienrf:play-jsmessages_2.11:2.0.0            (depends on 2.4.0)

[Gabor Fulop]

And maybe there is an unused ws dependency in 2.0.0? #44
I have an sbt version conflict for that too.

[Julien Richard-Foy]

I think the 2.0.0 version is really binary compatible with Play 2.4 and 2.5. But I’m ok to release another version (how would name it, though?) depending on 2.5 to avoid this warning.

[Gabor Fulop]

Thanks! Better safe than sorry.
Maybe 2.1.x?

[Julien Richard-Foy]

would you mind making a PR for that?

[Gabor Fulop]

Ok, I will do it.
But what about the branching? Will you create a new one for the PR? 2.x.x or 2.1.x?

[Julien Richard-Foy]

oh yes, I have to create the target branch now.

[Julien Richard-Foy]

You should target the 2.1.x branch.

[Gabor Fulop]

I created a PR for this issue but the CI fails for some reason. It want to compile with scala 2.10 which is not supported by play 2.5 anymore.

[Gabor Fulop]

Fixed by #47.

[Julien Richard-Foy]

I published the 2.1.0 version :)

[Gabor Fulop]

Thanks, and I just added it to my project, everything is okay now, the conflicts are gone.