julienrf / play-jsmessages

Library to compute localized messages of your Play application on client side

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Compatiblity with Play 2.2

manuelbernhardt opened this issue · comments

The plugin depends on 2.1 which causes a conflict when trying to use it with Play 2.2.x

A workaround is to exclude the scala-stm dependency:

"com.github.julienrf"    %% "play-jsmessages"     % "1.5.0" exclude("org.scala-stm", "scala-stm_2.10.0"),

An appropriate solution might be to mark the dependency as provided in the plugin build:

"com.typesafe.play" %% "play" % "(2.1,2.3)" % "provided"

Hi, I don’t think it is a good idea to mark the dependency as provided. I think I will just use the following revision expression: [2.1,). What do you think?

If this ensures that Play 2.1 is no longer a dependency when the plugin is
used in a 2.2 project that should do the trick as well.

On Tue, Sep 17, 2013 at 3:56 PM, Julien Richard-Foy <
notifications@github.com> wrote:

Hi, I don’t think it is a good idea to mark the dependency as provided. I
think I will just use the following revision expression: [2.1,). What do
you think?


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-24589764
.

I republished the artifact with the proposed changes. It works on my Play 2.2 app, please tell me if it works for you too. (I ddin’t change the artifact revision so you need to clear your ivy cache)

Hmm, it does not seem to have done the trick:

[info] Updating {file:/Users/manu/workspace/NexxPortal/}NexxPortal...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] downloading
http://julienrf.github.com/repo/com/github/julienrf/play-jsmessages_2.10/1.5.0/play-jsmessages_2.10-1.5.0.jar...
[info] [SUCCESSFUL ]
com.github.julienrf#play-jsmessages_2.10;1.5.0!play-jsmessages_2.10.jar
(1714ms)
[info] Done updating.
[error] Modules were resolved with conflicting cross-version suffixes in
{file:/Users/manu/workspace/NexxPortal/}NexxPortal:
[error] org.scala-stm:scala-stm _2.10, _2.10.0

Adding the following exclusions makes it work:

"com.github.julienrf"    %% "play-jsmessages"     % "1.5.0"

exclude("org.scala-stm", "scala-stm_2.10.0") exclude("play", "*"),

On Tue, Sep 17, 2013 at 6:36 PM, Julien Richard-Foy <
notifications@github.com> wrote:

I republished the artifact with the proposed changes. It works on my Play
2.2 app, please tell me if it works for you too. (I ddin’t change the
artifact revision so you need to clear your ivy cache)


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-24602752
.

I released a new version for compatibility with Play 2.2.