Don't background `parallel` for a single package
QuLogic opened this issue · comments
With the mass rebuild going on, I've been wondering why my builds are taking forever to even start, and I just realized it's because I used fbrnch parallel -F
and it passes --background
. This might make sense for a huge rebuild, but I'm just running like 2 or 3 builds.
Ah that's a fair point - maybe there should be some threshold for this (actually Fedora Koji seems to have quite a lot of capacity).
Maybe --background
should/could even be optional hmm. (Certainly not helpful during a Mass Rebuild... hehe;-)
(The only problem I have with a higher threshold is that it is rather arbitrary - it makes the behavior surprising to users.
Also it's not really the total number of packages but should be the number of concurrent builds.)
(I totally agree doing it for a single package is a no-brainer.)
We can easily start from there, though I can see someone in 6 months time
from now complain why their 2-3 packages didn't start building with parallel...
Also btw (only related but) the next release should have a build --no-prompt
option if that helps.
I think I will go with the following:
- parallel single package builds will be without --background always as you suggest
- also if there are no more than 5 concurrent packages in a parallel layer, they will also be at default priority.
I think these should give reasonable behavior in most use-cases. An override option could also be added.