fbrnch create-review requires a directory?

Question

fbrnch create-review requires a directory?

QuLogic opened this issue 4 years ago · comments

Elliott Sales de Andrade commented 4 years ago

I thought it used to accept spec files? But with 0.5-1.fc32, if I run fbrnch create-review R-brio.spec, it says:

fbrnch: No such directory: R-brio.spec

though the file is there.

Elliott Sales de Andrade · Answer 1 · Sun Sep 27 2020 14:03:00 GMT+0800 (China Standard Time)

Updated to 0.5-3.fc32, and it still does something like this.

So I moved the file into a subdirectory of ~/rpmbuild/SPECS and it worked better, but not quite right. It created the srpm in ~/rpmbuild/SRPMS (a bit unexpected though fine), but then after openin a Review Request, it started all over again.

Jens Petersen · Answer 2 · Mon Sep 28 2020 13:27:18 GMT+0800 (China Standard Time)

(One can run fbrnch create-review without an argument to use the current directory.)

You mean you want to create packages out of SPECS/?
Let me think a little on this.

I often wonder about whether to use the rpmbuild default ~/rpmbuild or not. Currently fbrnch just follows one's default settings for (non-distgit): personally I override rpmbuild to use the current directory.

Elliott Sales de Andrade · Answer 3 · Mon Sep 28 2020 13:45:15 GMT+0800 (China Standard Time)

Well, in 0.4, it was possible to specify a file and work on that. I have tons of stuff in SPECS, so picking the first file out of there doesn't work at all.

Jens Petersen · Answer 4 · Fri Oct 09 2020 23:45:45 GMT+0800 (China Standard Time)

spec filepaths should be supported now in the latest copr build.

Elliott Sales de Andrade · Answer 5 · Sat Oct 10 2020 18:05:05 GMT+0800 (China Standard Time)

Yep, working again.